Closed dave-mills closed 6 months ago
Introduction of New Variables in Database Procedure
In the database process related file, two new variables were introduced, one for tracking the count of distinct projects, while the other for the count of distinct organizations.
Conditional Checks on Project and Organisation Counts
The process will now check whether the project count is less than ten or if the organization count is less than three. This acts like a threshold check to ensure we have a significant number of both projects and organisations.
Setting a Boolean Based on Counts
There's a new boolean value being set based on the counts of projects and organizations. If there are too few projects or organizations, this boolean ('tooFewOtherProjects') turns ‘on’. This flag can then help in determining if certain actions need to be limited or warnings need to be raised elsewhere in the system.
Wording Change in Agreement Statement
There is a change in the wording for the data sharing agreement on the visualization page associated with displaying organization's information. The phrase "digitally signed the data sharing agreement" is being simplified to "agreed to the data sharing agreement", making it more accessible and easy to understand.
Thank you Dave.
I did below to update my local env:
git checkout dev
git pull
git checkout hotfix-anonymous-results
git pull
php artisan updatesql
npm run build
npm run dev
The two changes in this PR are working well.
In my local env testing, there is one thing unexpected.
In dashboard, it shows message "There is no fully assessed initiative" while we have fully assessed initiatives.
Thanks Dan,
Is the unexpected message something related to this hotfix, do you think? Should we investigate that here, or push this hotfix and then investigate it separately?
I just did a checking in live env, found that it also shows the same message "There is no fully assessed initiative". I have only one initiative, I have completed the assessment for red flags and principles.
Thanks Dan,
Is the unexpected message something related to this hotfix, do you think? Should we investigate that here, or push this hotfix and then investigate it separately?
I think the unexpected message is not related to this hotfix. As it is also showed in live env...
Let's investigate it separately.
In the main organisation dashboard, currently the code to hide "other institutions' results" when there are too few results to be anonymous is disabled.
This PR re-enables that feature and fixes an issue with the checking. Now, When there are fewer than 10 projects and 3 separate organisations contributing to any filtered set of results, the results will be hidden for other institution's initiatives.
Screenshot of what should happen when filters are applied to return a results set that is too small: