stats4sd / aec_portfolio

A proof of concept for the AEC Consortium Project Management / Assessment System
GNU General Public License v3.0
0 stars 0 forks source link

Hotfix anonymous results #258

Closed dave-mills closed 6 months ago

dave-mills commented 6 months ago

In the main organisation dashboard, currently the code to hide "other institutions' results" when there are too few results to be anonymous is disabled.

This PR re-enables that feature and fixes an issue with the checking. Now, When there are fewer than 10 projects and 3 separate organisations contributing to any filtered set of results, the results will be hidden for other institution's initiatives.

Screenshot of what should happen when filters are applied to return a results set that is too small: CleanShot 2024-03-18 at 10 55 04

what-the-diff[bot] commented 6 months ago

PR Summary

dan-tang-ssd commented 6 months ago

Thank you Dave.

I did below to update my local env:

git checkout dev
git pull
git checkout hotfix-anonymous-results
git pull
php artisan updatesql
npm run build
npm run dev

The two changes in this PR are working well.

In my local env testing, there is one thing unexpected.

In dashboard, it shows message "There is no fully assessed initiative" while we have fully assessed initiatives.

image

dave-mills commented 6 months ago

Thanks Dan,

Is the unexpected message something related to this hotfix, do you think? Should we investigate that here, or push this hotfix and then investigate it separately?

dan-tang-ssd commented 6 months ago

I just did a checking in live env, found that it also shows the same message "There is no fully assessed initiative". I have only one initiative, I have completed the assessment for red flags and principles.

image

image

dan-tang-ssd commented 6 months ago

Thanks Dan,

Is the unexpected message something related to this hotfix, do you think? Should we investigate that here, or push this hotfix and then investigate it separately?

I think the unexpected message is not related to this hotfix. As it is also showed in live env...

Let's investigate it separately.