Add custom assessment criteria

[dave-mills]

This PR fixes #40. It adds a new "Custom" AssessmentCriteria model.

• Institutions can create their own assessment Criteria.
• These are specific to each institution.
• The assessment follows the same process as for each AE Principle, but it's separated into their own page.
• This is all handled via a new AssessCustomOperation trait - cloned from the AssessOperation trait and adapted to use the AssessmentCriteria instead of the Principle model.

NOTE: I suggest merging in the previous #54 first as it'll make it easier to review this branch.

TODO:

• [x] confirm if custom_score_tags are needed for custom assessment criteria.
• [x] make ordering of criteria on the assessment page match the custom ordering in the AssessmentCriteriaCrud
• [ ] ~Fix assessment status (right now it's marked as complete if either section is done. We need 2 separate statuses to mark when each is complete and then an overall completion status.~

[dave-mills]

Update:

• score tags and custom score tags implimented for "additional assessment criteria"
• ordering for additional assessment criteria is now by default using the lft property that's changed by the ReorderOperation.

I'm not going to fix the status here, because after a discussion with Emily we're going to modify the assessment status and how it is presented anyway, so we'll do that in a separate PR.

[dan-tang-ssd]

Thank you Dave.

I checkout dev branch, get latest code. Performed testing successfully for review readlines and assess project. Then checkout this branch, get latest code. Run migration files.

Below please find my testing result FYI.

Main menu

• Added new item "Custom Assessment criteria"
• Another 3 new items at lower left corner, they either return error 404 or 405... do we need to show them in main menu?

[dan-tang-ssd]

Performed below testing with positive result:

1. Create new additional criteria, with examples
2. Create new additional criteria, without example
3. Reorder additional criteria

A very minor question, should we be consistent in menu item name and CRUD panel name?

[dan-tang-ssd]

Project CRUD panel, list view, added new button "Assess Additional Criteria".

In database, corresponding additional_criteria_assessment records for existing assessments also created automatically after adding a new additional criteria.

In additional criteria 1, I ticked custom score tags then saved

When I come back from additional criteria 2 to additional criteria 1, my ticked custom score tags are not ticked...

[dan-tang-ssd]

I performed testing for adding custom score tags.

• For additional criteria without score tag, custom score tag can be added successfully.
• For additional criteria with existing score tags, custom score tag cannot be added.

---

Additional criteria 2, it does not have any score tag. Custom score tag can be added successfully.

---

Additioanl criteria 1, it has two score tags. Custom score tag cannot be added.

[dave-mills]

Oops - I somehow managed to put that example / custom example save outside the foreach loop inm the AssessCustomOperation before committing. Thanks for finding that.

Should be all fixed in the latest commit - tested just now locally and I was able to properly save + retrieve examples + custom examples for multiple additional criteria.

[dan-tang-ssd]

Thank you Dave.

I got latest code and run migration files again. Then performed same testings with positive result. All mentioned items fixed.

I think it is good to merge it into dev branch now.