Closed dan-tang-ssd closed 2 weeks ago
Up to this point, This PR can support below core features for issue #1
The remaining features of issue #1 will be developed later. I will now move to work on issue #2 first.
Hi @dave-mills
I create two branches "add-team-invite-feature" and "add-filament-odk-link" for issue #1 and #2 respectively.
For issue 2, admin panel Xlsform Template resource is working fine now. I am going to add ODK Form Management page in app panel. (I copied TeamOdkView, HelperService, XlsformResource from tape-data-system)
I realised that the changes I made in issue 1 needs to be used here for issue 2, e.g. filament multi-tenancy for User model. I need those program changes to further proceed. But it will become messy if I copy the modified program files from "add-team-invite-feature" branch to "add-filament-odk-link" branch.
In this case, should we merge two partially done PRs into dev branch, and then create new branch to continue the remaining development work?
To have the latest code from both branches to continue further development work, can I merge these two branches into a new branch "wip" first? (I created "wip" branch based on "dev" branch)
Many Thanks.
In this case, should we merge two partially done PRs into dev branch, and then create new branch to continue the remaining development work?
To have the latest code from both branches to continue further development work, can I merge these two branches into a new branch "wip" first? (I created "wip" branch based on "dev" branch)
Either sounds like a good approach. Given these PRs are merging into 'wip', lets do that 👍. Thanks!
After a quick look through, this looks good. I haven't gone into detail, but I think that's ok at this point, and we can review it together with the other PR when merging back from wip into main.
Btw - I like the 'signed' url use. Haven't seen that before, and looks like a neat approach to handling tokens for invitations.
This PR is submitted to fix #1
@dave-mills It is now WIP, not yet ready for review.
I submitted this PR is for progress update.
Copied team-invite feature from AEF, including below changes:
WIP:
Example registration link:
http://holpa-platform.test/register?token=XtxMoAyPpQAL4pDwXh1tKqoO&signature=d325a7885c9635cbfb75ff6270c1ff38797a49eb072f11c84f52ba81eea3c66f
Screen shot, it shows app panel login page instead of registration page: