search

statsig-io / dotnet-sdk

Statsig SDK for .NET applications on both client and server sides
ISC License
2 stars 6 forks source link

Switch to license expression & set repo url #38

Closed thompson-tomo closed 4 months ago

thompson-tomo commented 5 months ago

Summary

I wish for the nuget packages to have the licence expression property set correctly and the repository url

Details

The licence expression property should be set to the correct licence type I.e. Apache-2.0 as this will enable analysis of licences in use to occur in external tools & the license type will be shown in Nuget etc. By providing the repo url it will make it easier to contribute and can be used by source-link.

kenny-statsig commented 5 months ago

Hey @thompson-tomo we can patch in the repository URL but will leave the license as is. I'd prefer to point to the same license in Github

thompson-tomo commented 5 months ago

@kenny-statsig the issue is external tools can not then do license analysis of the libraries being used. My workplace do that for all developments hence are needing a license expression. At the same time it improves the developer expereicence in NUGET as easily instantly visible what type of license applies, hence would suggest reconsidering this.

tore-statsig commented 5 months ago

Reopening until this is complete. Adding the license should be fine, but this repository (and all of our SDKs) are under the ISC license, not MIT

thompson-tomo commented 5 months ago

My apologies @tore-statsig not sure how I made that mistake but will correct it