search

statsig-io / go-sdk

A golang SDK for interfacing with Statsig Feature Gates, Dynamic Configs, and A/B Experiments
ISC License
8 stars 10 forks source link

Log message when there are no updates to specs #28

Closed jakegavin closed 1 year ago

jakegavin commented 1 year ago

Currently, Statsig logs "Failed to process specs" when there are no updates to the specs here. "Failed" makes it sound like something has gone wrong but if I'm understanding this correctly, this is the most common scenario. As a result, we're seeing failure messages in our logs every 10 seconds. What do y'all think about changing the phrasing of this message to something along the lines of 

s.logProcess("Processing specs...")
if specs.HasUpdates {
    // process updates
} else {
  s.logProcess("No updates found")
}
s.logProcess("Done processing specs")

Am I misunderstanding something and this is specs.HasUpdates false is actually a bad state to be in?

jkw-statsig commented 1 year ago

This does seem weird, we will take a look

kenny-statsig commented 1 year ago

Updated the message to show "No updates to specs"