gblee0410
commented
3 years ago Hi, I'm GB who is a Product Designer on Statsig. Thanks for using our product and providing this valuable feedback 👍
I'm here to give an update on this issue -- we've finalized the designs and our engineers will start working on it this week. Here are some of the things you can expect (for all the new updates, I've included some screenshots that illustrates our approach):
- We'll be adding a project-level setting where the admin can set if all the feature gate changes need review or not
- For projects that enabled the mandatory review setting, feature gate changes will require submission of the reviewers (from the same project) and a short description of the changes made
- There will be a "Preview State" view where the person who requested the change can make additional changes or to cancel the submission. For others, they can either approve or reject. (Note: we are opening up the ability to approve by anyone in the project, not just the people who were defined to be reviewers
- On feature gates that is pending review, we will be highlighting at the very top with description & reviewer information as well as the link to the "Preview State" to view the changes requested
- We will be introducing a new page called "Review" where you can view all your current & past feature gate reviews. Upon getting requests to be a reviewer, we will trigger a notification and send you an email
- Lastly, in the feature gate tab view, anyone in the same project will be able to see feature gates that have pending reviews from the tag
sroyal-statsig
One feature that I think would be really great to have is the ability to submit a change for review from your other teammates before it takes effect. This would help to mitigate risk around accidental feature targeting changes or incorrect configurations on dynamic configs.