search

statsmaths / cleanNLP

R package providing annotators and a normalized data model for natural language processing
GNU Lesser General Public License v2.1
209 stars 36 forks source link

Remove unnecessary properties file from package #55

Closed jefshe closed 4 years ago

jefshe commented 4 years ago

Relates to #54

I think this approach is better as it avoids the unnecessary IO of reading and writing the RDS file as well as avoiding contention issues if multiple R processes are running cleanNLP

statsmaths commented 4 years ago

Thanks for submitting this. As you mention in #54, it does make more sense to make the properties file live in lib_location. However, if I am reading you commit correctly, this pull request doesn't do that correct? It just remove the properties file entirely?

And to clarify why this is needed, it's the only way at the moment to manually adjust the way the coreNLP pipeline works and follows the same format as the properties files supplied by the coreNLP library.

jefshe commented 4 years ago

I see, in that case, would you accept a PR that reads in the properties file from lib_location and then in setup_corenlp_backend_raw alters the object in memory rather than writing back and forth to disk?