status-im / airbyte-custom-connector

Repository holding all of Airbyte Custom Connector used in Status
1 stars 1 forks source link

Simplecast Connector Issues #12

Closed JoseAnaya28 closed 3 weeks ago

JoseAnaya28 commented 2 months ago

@apentori

apentori commented 2 months ago

The API is well done and the pagination is easy to add.

There is something that bother me however: the analytics endpoints like : analytics/location or analytics/episode?podcast=id don't appear in the documentation. Will they disappear ?

Adding the analytics?epidode endpoint is doable, however how do i name the object ? analytic_episode is already used for the object from analytics/episodes?podcast.

apentori commented 2 months ago
airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: https://api.simplecast.com/analytics?episode=6677f85d-b41e-4c2e-ae28-0f22b1132455, Response Code: 429, Response Text: {"status":429,"href":null,"error_message":"You have exceeded your api key request quota for this account","error":"too_many_requests"}

We might have an issue here, it's probably due to my multiple test

apentori commented 2 months ago

https://github.com/status-im/airbyte-custom-connector/commit/204812e8f8af9f74dff7de896de379dea310d4d3

I will update the connector later, when the API has reset the quota

apentori commented 2 months ago

https://help.simplecast.com/en/articles/2724796-simplecast-2-0-api#versioning

We will add a versioning option to the header soon. But, rest assured, we won't make any breaking changes in the meantime.

We should be good for the old endpoint.

JoseAnaya28 commented 2 months ago

Adding the analytics?epidode endpoint is doable, however how do i name the object ? analytic_episode is already used for the object from analytics/episodes?podcast.

We can name it: analytics_episode_downloads

apentori commented 1 month ago

The table analytic_episode_download is already available in bi.prod, i totally forgot to send a message. Does this table and `analytic_episode_download_by_interval' hold all the data that you need ?

JoseAnaya28 commented 1 month ago

Awesome! Looks like it, I'll test it and let you know if there's any issues