search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Controller can Reclaim ENS node without going thorugh migration process #100

Closed 3esmit closed 3 years ago

3esmit commented 4 years ago

UsernameRegistrar.sol was designed to hold deposits of users with the right of reclaim in case of a migration/change of contract.

BaseImplmentationRegistrar.sol, which owns .eth, allows the reclaim of ENS node by the NFT owner of that domains. This is very useful for migration, but it would break the UsernameRegistrar.sol contract.

In case Reclaim function is used, instead of the planned migration, the funds of users will be stuck in the contract, breaking the intended behavior of the contract.