search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Usernames market is part of UsernameRegistrar.sol #108

Closed 3esmit closed 3 years ago

3esmit commented 4 years ago

In order to allow easier change of the payment logic, the registrar should not handle anything else then a public ledger (NFT).

This change would facilitate any future feature, such as changing payment token address, or anything.

The payment, locking and slashing conditions should be isolated from the registrar to enable future proofing.

3esmit commented 4 years ago

108 makes upgradability smoother, because without it the migration process would be "every user needs to be migrated individually to a new registrar" as is the current behavior, but with the separation of the NFT ledger on a migration event the new Username Registrar will become the new controller of this ledger, meaning that all users are migrated at once, and the NFT address won't change.