search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

ETH transaction details are shown in wallet screen when registering ENS username #11

Open asemiankevich opened 6 years ago

asemiankevich commented 6 years ago

When user initiates the transaction to register ENS name for 50 SNT charge this is expected wallet screen:

image

As an actual result i see ETH transaction which confuses me

image

jeluard commented 6 years ago

Probably related to this initiative

The ENS subdomain contract triggers a SNT transferm from this line

bgits commented 6 years ago

Would implementing this EIP help?

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md

asemiankevich commented 6 years ago

@bgits this isssue was dicussed here https://status-im.slack.com/archives/CA7R1RK0C/p1536831651000100 please jump in if you like!

dmitryn commented 6 years ago

Would implementing this EIP help?

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md

@bgits yes, it should help with UX. Currently status wallet receives tx data:

{"jsonrpc":"2.0","id":18,"method":"eth_sendTransaction","params":[{"data":"0x095ea7b30000000000000000000000009e183bc54bb4f3cca1a478ca6f2c3edc37b60478ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","from":"0x511dd326814ea99881c08e4ba43a1463624e9aa7","gasPrice":"0x3b9aca00","to":"0xc55cf4b03948d7ebc8b9e8bad92643703811d162"}]}

to enable SNT allowance and the issue is user don't see what he's actually signing. The same issue happens when we ask to transfer 50 SNT.