search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Controlled.changeController(address) lacks a zero-check on _newController and also lacks an event #116

Closed ghost closed 4 years ago

ghost commented 4 years ago

Controlled.changeController(address)._newController lacks a zero-check on :

and also lacks emitting an event for this critical parameter change.

Recommendation: Check that the address is not zero and also emit an event.