search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Contact code request happens on page load #17

Closed rachelhamlin closed 5 years ago

rachelhamlin commented 6 years ago

The contact code should only be requested when the user has tapped the contact code field, while registering a name.

image

bgits commented 6 years ago

So the contact code field will be empty until it's touched?

rachelhamlin commented 6 years ago

Yes, permission should be granted in context and on a per-ID basis. With the new EIP1102 pattern, we'll need to add a trigger for the wallet, too.

On Thu, Sep 13, 2018 at 9:03 PM Barry G notifications@github.com wrote:

So the contact code field will be empty until it's touched?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/status-im/ens-usernames/issues/17#issuecomment-421134863, or mute the thread https://github.com/notifications/unsubscribe-auth/AOwPY5Sxqqj5rea50gcCZqjuxQRHG-Kwks5uarodgaJpZM4WoCqB .

bgits commented 6 years ago

My thinking was that we ask for permission once upon the dapp loading then we can use the code throughout the dapp. Otherwise ask each each time the dapp needs access to the contact code?

I don't believe the the wallet address is uses the EIP yet?

rachelhamlin commented 5 years ago

Ask each time the DApp needs access - it should be optional for each name registered by the user.

bgits commented 5 years ago

Opened a PR to request contact code when tapped.

https://github.com/status-im/ens-usernames/pull/32/files

rachelhamlin commented 5 years ago

🙌

On Mon, Oct 1, 2018 at 4:43 PM Barry G notifications@github.com wrote:

Opened a PR to request contact code when tapped.

https://github.com/status-im/ens-usernames/pull/32/files

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/status-im/ens-usernames/issues/17#issuecomment-426055991, or mute the thread https://github.com/notifications/unsubscribe-auth/AOwPY0SUjWeCQ53jyqYEdlmgsMOdH6b5ks5ugn6NgaJpZM4WoCqB .