search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Add date of registration to taken names #28

Closed rachelhamlin closed 5 years ago

rachelhamlin commented 5 years ago

When I search for a name that is already registered, I should see the date that it was registered.

Expected image

Current image

bgits commented 5 years ago

You want the date registered or the date it can be released?

bgits commented 5 years ago

Added date of registration in this commit: https://github.com/status-im/ens-usernames/pull/32/commits/b4f3d09010796554e86f6be4085b6aca84258a4e

rachelhamlin commented 5 years ago

Yes date of registration 👍🏼

bgits commented 5 years ago

Ok, it's in the PR. The one issue is it will only be available on names that were registered using the most recent registry, for it to be available on names registered when stateofus.eth was owned by another registry the username has to moved to the new registry and we don't expose that method in our UI.

rachelhamlin commented 5 years ago

Okay, noted. So if we change stateofus.eth ownership over to the #status-root multisig, the first names registered after launch will be affected?

bgits commented 5 years ago

If we transfer stateofus.eth to another registry contract that we deploy in the future, all names registered on the original contract will be impacted. On launch, having only one contract ever for registrations on mainnet will have no impact.

rachelhamlin commented 5 years ago

Makes sense. Will keep mental note of that.