search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Contact code box doesn't prompt permission flow #36

Closed rachelhamlin closed 5 years ago

rachelhamlin commented 5 years ago

Tapping contact code box to add my chat ID during registration doesn't trigger the permission flow.

I have granted contact code permission in the past with this account (when permission was triggered on page load).

After tapping contact code box:

iOS https://cloudflare-ipfs.com/ipfs/QmUKjgCRreGjgEzxYuK3Y2HXn4hMr36LnnduhVYo8JVwzR/

bgits commented 5 years ago

Has status moved over to the new api?

rachelhamlin commented 5 years ago

Not yet. Right now developers can only test the new implementation, but the idea was not to force it until November (and we can not support both in parallel). This is pretty annoying, but hopefully the long lead time will help more developers prepare before things break.

On Sun, Oct 7, 2018 at 9:02 PM Barry G notifications@github.com wrote:

Has status moved over to the new api?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/status-im/ens-usernames/issues/36#issuecomment-427702000, or mute the thread https://github.com/notifications/unsubscribe-auth/AOwPYwSwxfUs411Ce6sAycRl3aGmLaOJks5uiqRCgaJpZM4XMHMM .

bgits commented 5 years ago

The action is being triggered according to the old Status API, the same action that was being triggered on page load. What version of Status is this tested with?

rachelhamlin commented 5 years ago

I'm on the nightly (Oct 8 now).

flexsurfer commented 5 years ago

new Status API is merged, and in nightly already, you can find new docs here https://docs.status.im/developer_tools/status_web_api.html, sorry for the confusion, so we need to update Dapp according to latest Status API

bgits commented 5 years ago

PR opened here: https://github.com/status-im/ens-usernames/pull/42/files

bgits commented 5 years ago

Version for testing can be found here: https://cloudflare-ipfs.com/ipfs/QmfY6UaussfWdUKvmUnCwZxNiMJnQEXbkdAF5MBprbejEf/

flexsurfer commented 5 years ago

@bgits https://github.com/status-im/ens-usernames/pull/42#discussion_r223583362

bgits commented 5 years ago

@bgits #42 (comment) @flexsurfer https://github.com/status-im/ens-usernames/pull/43/files

bgits commented 5 years ago

updated version: https://cloudflare-ipfs.com/ipfs/QmSJXVfcxU1sTpTsSTidUaFgFfu9DzusaSJSBwE6BzFcxr/

rachelhamlin commented 5 years ago

Nice!