Closed bgits closed 5 years ago
@bgits Have you seen my comments?
You probably want to squash your commits
Squashed
One more thing that came to mind reviewing this PR. This component can actually be a web3 UI component as preRegisteredCallback
and registeredCallbackFn
can support an optimistic UI for ENS, we just need to add a registrationFailed
prop and that will allow the UI to update instantly when the user submits a TX but rollback and inform the user that the transaction actually failed.
You probably want to squash your commits