Fix confirmation screen

status-im / ens-usernames

DApp to register usernames for Status Network

MIT License

19 stars 11 forks source link

Fix confirmation screen #54

Closed bgits closed 5 years ago

jeluard commented 5 years ago

You probably want to squash your commits

jeluard commented 5 years ago

@bgits Have you seen my comments?

bgits commented 5 years ago

You probably want to squash your commits

Squashed

bgits commented 5 years ago

One more thing that came to mind reviewing this PR. This component can actually be a web3 UI component as preRegisteredCallback and registeredCallbackFn can support an optimistic UI for ENS, we just need to add a registrationFailed prop and that will allow the UI to update instantly when the user submits a TX but rollback and inform the user that the transaction actually failed.