search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

User can register domain without giving permissions to the dapp #57

Closed asemiankevich closed 5 years ago

asemiankevich commented 5 years ago
  1. Open status
  2. Open ens dapp
  3. Search for some free domain
  4. Tap register with transaction and proceed

Expected:

  1. user should be asked about permissions before registering the domain
  2. if i granted the dapp with permissions on a device and then created new account in status - user should be asked about permissions again
rachelhamlin commented 5 years ago

Actually not a bug - there should be a Grant access CTA in the chat ID box, and only if a user taps on that are they prompted to grant profile permissions.

See this issue - https://github.com/status-im/ens-usernames/issues/38

Closing for now; we can discuss if this should be change during phase 2.