search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Resolution issue with `carl` #75

Closed chadyj closed 5 years ago

chadyj commented 5 years ago

By now everyone has heard the story of trying to chat with carl and getting a random Chinese dude! There was much laughs at the thought of a squatter.

But after digging deeper it looks like that Carl registered his name but for the contact code wasn't captured.

screen shot 2018-10-26 at 5 53 49 pm

So we have these potential issues:

  1. Contact code potentially not saved (Carl thought he did, but isn't 100% certain)

  2. carl resolves to 0x04ee8c9662467fbce7398d5d9591a5b3657ba6f487bdfc33dd6d053d6252b36ba09b9d9cba387ab267e607807709195135fca1ccb8a81a6931ee67079975f9091c, but it shouldn't resolve at all since there isn't a contact code saved (see screenshot above or search for carl in the dapp)

Can we verify #1 and also fix the issue when we resolve incorrectly?

cc @rachelhamlin @3esmit @bgits @yenda @naghdy

chadyj commented 5 years ago

oh and one more thing....

  1. How can Carl edit his ENS name and update the contact code?
oskarth commented 5 years ago
  1. No management API yet, so can’t edit contact code in UI.
  2. contact code not granted, so resolved to 0 pub key, this should be validated in UI
  3. UX around grant code a bit so so, many people missed this
3esmit commented 5 years ago

Issue is caused in status-react when resolving pubkey x = 0 and y = 0. When both are 0, it should not continue, perhaps show an error message

yenda commented 5 years ago

@3esmit actually this is not the problem, the problem is that the chinese guy registered c (https://etherscan.io/enslookup?q=c.stateofus.eth) so that name was resolved and since carl doesn't resolve to a valid address, the resolution of c to the public-key of the chinese guy was staying in the app state. I fixed the input so that now resolution of a shorter username is discarded as soon as you add additional characters in this PR https://github.com/status-im/status-react/pull/6537

chadyj commented 5 years ago

Closed in https://github.com/status-im/status-react/pull/6537

rachelhamlin commented 5 years ago

Still having this issue on desktop, when I enter carl or bruce, for example. It should be fixed in the desktop builds right @yenda?

yenda commented 5 years ago

carl doesn't resolve for me either because it isn't associated with public-key, but bruce does

rachelhamlin commented 5 years ago

bruce is also working for me this morning 🤷🏼‍♀️