Translate ENS Dapp! - Githubissues

chadyj commented 5 years ago

We have users all over the world. Let's give them the ENS dapp in their local language. 🇺🇸 🇨🇳 🇫🇷 🇯🇵

The mobile app uses Lokalise to manage the translation of strings and we have a nice UI to manage the translations then a git-based workflow to commit and review changes.

The mobile app uses react-native-i18n, but for this dapp you can use one of these supported file formats https://docs.lokalise.co/supported-file-formats such as json

Once there is a compatible strings file I'd be happy to help setup things on the Lokalise side. Just ping me :)

rachelhamlin commented 5 years ago

Adding a bounty to this one.

The ask is to format all the ENS DApp strings into a Lokalise compatible file, e.g. JSON. (cc @bgits for any support)

chadyj commented 5 years ago

Another example is status.im using YAML over here https://github.com/status-im/status.im/tree/develop/themes/navy/languages

Perhaps @PierrickGT might be interested who just did some translation work at status.im?

PierrickGT commented 5 years ago

@chadyj yes, I am interested by this task. I've already done some similar work for Balance.

You can see what I've worked on in the following PR: https://github.com/balance-io/balance-wallet/pull/103 https://github.com/balance-io/balance-common/pull/6 https://github.com/balance-io/balance-manager/pull/315

chadyj commented 5 years ago

Sweet @PierrickGT! Good luck! Ping me when you have the EN language file and I'll add to Lokalise then get translators gong :)

We also need a way to detect and set the language, and perhaps a way to let the user change the language. WDYT @rachelhamlin ?

PierrickGT commented 5 years ago

@chadyj will you add a bounty on Gitcoin in the coming days?

rachelhamlin commented 5 years ago

@PierrickGT can you handle device-based language detection as part of this bounty? I'm bumping it up to a medium.

@andytudhope will help us get this funded!

PierrickGT commented 5 years ago

@rachelhamlin yes, I can handle device-based language detection with i18n-js.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it as part of the Status.im fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $38,202.91 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 years, 2 months ago. Please review their action plans below:

1) lorissikora has applied to start work _(Funders only: approve worker | reject worker)_.

I‘m intetested. Could translate to german. 2) pierrickgt has been approved to start work.

I'll first setup i18n-js to detect and load which language should be use depending on the device language. I will then replace text strings in the app by the i18n function to translate the string in the appropriate language.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

@pierrickgt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

PierrickGT commented 5 years ago

@chadyj @bgits how can I test the app in local development? Cause I'm connected on the Ropsten network through Metamask but after clicking on the Let's Go button, I get this error message: Please connect to Ethereum Development to continue.

I'm connected to the local blockchain running but I've got an error in the console saying that the connection to the endpoint http://localhost:5001/api/v0/id?stream-channels=true is refused.

rachelhamlin commented 5 years ago

@PierrickGT could be an issue with browser privacy mode. What happens if you toggle that off from within the profile?

PierrickGT commented 5 years ago

@rachelhamlin you mean in my browser or in the app? Cause I don't see any profile section in the app.

bgits commented 5 years ago

A different version needs to be launched for Ropsten. If your developing locally you can run the command embark run testnet

On Mon, Nov 26, 2018 at 5:30 PM Pierrick TURELIER notifications@github.com wrote:

@chadyj https://github.com/chadyj @bgits https://github.com/bgits how can I test the app in local development? Cause connected on the Ropsten network through Metamask but after clicking on the Let's Go button, I get this error message: Please connect to Ethereum Development to continue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/ens-usernames/issues/76#issuecomment-441825335, or mute the thread https://github.com/notifications/unsubscribe-auth/AD1YSKgxyxSkcJS9Pgikq-qUJvFNiNp3ks5uzGtpgaJpZM4X8jy- .

PierrickGT commented 5 years ago

A different version needs to be launched for Ropsten. If your developing locally you can run the command embark run testnet … On Mon, Nov 26, 2018 at 5:30 PM Pierrick TURELIER @.***> wrote: @chadyj [@chadyj](https://github.com/chadyj) @bgits [@bgits](https://github.com/bgits) how can I test the app in local development? Cause connected on the Ropsten network through Metamask but after clicking on the Let's Go button, I get this error message: Please connect to Ethereum Development to continue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#76 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AD1YSKgxyxSkcJS9Pgikq-qUJvFNiNp3ks5uzGtpgaJpZM4X8jy-> .

Still no luck with embark run testnet.

PierrickGT commented 5 years ago

@chadyj @bgits @rachelhamlin I've finished to add the translation on all the pages. I'm awaiting your review approval before sending my work through Gitcoin.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by:

@pierrickgt

@StatusSceptre please take a look at the submitted work:

PR by @PierrickGT

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$34,208.29 more funded OSS Work available on the Gitcoin Issue Explorer

chadyj commented 5 years ago

Thank you @PierrickGT! The changes have been merged and translation files imported into Lokalise.

Next, we need contributors to translate the 471 words.

We have @jinhojang93 to do Korean. @PierrickGT already did French.

Would love to get Chinese, Farsi, and Russian too. Actually all languages sound good!

@pablanopete @j-zerah Can you help get some translators together? (or alternatively we can pay for it via a service for a quick turn around)

rachelhamlin commented 5 years ago

Thanks so much @PierrickGT and @chadyj for managing. What's the best way to filter for the ENS strings on Lokalise?

We have someone who can translate to Chinese here in China.

chadyj commented 5 years ago

Thanks so much @PierrickGT and @chadyj for managing. What's the best way to filter for the ENS strings on Lokalise?

We have someone who can translate to Chinese here in China.

Sweet!

AENS DApp project is setup with just the ENS strings. Its ready to go :)

rachelhamlin commented 5 years ago

@chadyj got it. Will share with our Chinese community member :)

jinhojang6 commented 5 years ago

Hi all, can I get the context or screens of these strings?

Nice!
Of
Ethereum address domain resolves to
Status messenger address domain resolves to
Read your account token balance
Read account token balance

chadyj commented 5 years ago

Thanks @jinhojang93! Super fast work :)

Hi all, can I get the context or screens of these strings?

@bgits @3esmit @rachelhamlin Got screenshots of these? I couldn't find it.

btw I uploaded several other screenshots and uploaded to Lokalise for translating context.

gitcoinbot commented 5 years ago

⚡️ A *Javascript Master Scriber* Kudos has been sent to @PierrickGT for this issue from @StatusSceptre. ⚡️ Nice work @PierrickGT! Your Kudos has automatically been sent in the ETH address we have on file.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @PierrickGT.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$35,345.84 more funded OSS Work available on the Gitcoin Issue Explorer

rachelhamlin commented 5 years ago

The DApp shows extra content if you load it from a normal browser using MetaMask, e.g.

Would be great to ultimately remove that content & make it consistent with the mobile version, but @bgits do you recognize these particular strings from @jinhojang93?

TouchstoneTheDev commented 8 months ago

Hi I would like to translate the strings, I have previous experience also !

status-im / ens-usernames

Translate ENS Dapp! #76