search

status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

ensure proper XY coordinate generation from key for contact code #82

Closed bgits closed 5 years ago

jeluard commented 5 years ago

@bgits Can you provide more details about what the issue was and how it's fixed?

bgits commented 5 years ago

@bgits Can you provide more details about what the issue was and how it's fixed?

yes, sorry the diff is larger than it should be. The issue was with lines 9 & 10. 

  const x = '0x' + pubPoint.getX().toString(16, 64)
  const y = '0x'+ pubPoint.getY().toString(16, 64)

The toString method was being called without the second parameter supplied.

jeluard commented 5 years ago

Not clear what it's solving but will trust you!

rachelhamlin commented 5 years ago

Did we deploy this fix to IPFS @bgits?

bgits commented 5 years ago

yes

On Tue, Nov 20, 2018 at 10:42 AM Rachel Hamlin notifications@github.com wrote:

Did we deploy this fix to IPFS @bgits https://github.com/bgits?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/ens-usernames/pull/82#issuecomment-440319040, or mute the thread https://github.com/notifications/unsubscribe-auth/AD1YSO5E9Vh2-O3dtO9JpRit_a0lwvAXks5uxCL2gaJpZM4YQ-iu .

rachelhamlin commented 5 years ago

And was the ENS resolver updated by @3esmit?

corpetty commented 5 years ago

the second parameter specifies required length, correct?

rachelhamlin commented 5 years ago

Following up on this one. @3esmit @bgits is this version of the DApp (all contact codes can be edited) the one we resolve to via ENS? Unfortunately can't manually test myself as the issue was not affecting me.