status-im / ens-usernames

DApp to register usernames for Status Network
MIT License
19 stars 11 forks source link

Add i18n translation #85

Closed PierrickGT closed 5 years ago

PierrickGT commented 5 years ago

Issue: https://github.com/status-im/ens-usernames/issues/76

chadyj commented 5 years ago

Nice one! @bgits @jeluard @3esmit please take a look

chadyj commented 5 years ago

@PierrickGT What's your plan for the other text that hasn't yet been converted to strings?

3esmit commented 5 years ago

How the language is changed? Automatically based on system configuration?

PierrickGT commented 5 years ago

@PierrickGT What's your plan for the other text that hasn't yet been converted to strings?

I'm working on it. :) I'll also include a French translation.

How the language is changed? Automatically based on system configuration?

For now yes, you can't change it in the app and it defaults to English if we don't have the translation file.

chadyj commented 5 years ago

@3esmit this is ready to go. can you please review?

chadyj commented 5 years ago

@3esmit @bgits Thank you for the review. Can you please merge this contributor bounty PR so translation work can start?