3esmit
commented
5 years ago consider importing only the languages needed, not all.
Closed status-im-auto closed 5 years ago
3esmit
commented
5 years ago consider importing only the languages needed, not all.
chadyj
commented
5 years ago in app/languages/index.js, line 3 and 4, the var fr is wrong. Should be the respective language abbr.
Good catch. Fixed.
consider importing only the languages needed, not all.
Can you clarify?
3esmit
commented
5 years ago consider importing only the languages needed, not all.
Can you clarify?
The languages not used by user are also imported, consider importing only the language selected by user. Importing all languages can make the dapp slower if there is too much strings and languages, as they would be loaded in memory but not used.
chadyj
commented
5 years ago Importing all languages can make the dapp slower if there is too much strings and languages, as they would be loaded in memory but not used.
This PR is focused on the language files and is auto-generated from a translation service. Changing how the localization works is out of scope for this PR :(
You may want to create a new bounty to update this behaviour or amend https://github.com/status-im/ens-usernames/pull/85 where the translation work was done.
What can we do to get these languages merged so we can better serve our international users?
rachelhamlin
commented
5 years ago @3esmit I think we should make the trade off for speed right now and allow more people to register. I'll create a new bounty for the adjustment, okay?
chadyj
commented
5 years ago @asemiankevich translations updated. Thanks!
3esmit
commented
5 years ago Lgtm
This is an extension of https://github.com/status-im/ens-usernames/pull/85 by @PierrickGT that adds Korean and Russian translations.
The ko.json and ru.json files were generated automatically from Lokalise (web app to easily manage translations), and the translations were enabled in index.js.
These need to be tested to make sure they display correctly.