search

status-im / geth_exporter

geth metrics exporter for Prometheus
Mozilla Public License 2.0
13 stars 3 forks source link

Allow the debug_metrics call to fail #23

Closed jakubgs closed 5 years ago

jakubgs commented 5 years ago

Starting from 1.9.0 Geth removed the debug_metrics RPC call

For more details see release noted for 1.9.0:

The original geth monitor CLI command was removed along with its supporting debug_metrics RPC API endpoint. Anyone relying on monitoring should use the ExpVar, InfuxDB or Prometheus metrics reporting along with Datadog or Grafana.

https://blog.ethereum.org/2019/07/10/geth-v1-9-0/#compatibility

jakubgs commented 5 years ago

@gravityblast are you cool with this change?

adambabik commented 5 years ago

Generally, this project might be not needed anymore or might be simplified because geth exposes metrics through expvar now.

This means that for statusgo running on servers, we probably would like to start a server like http.ListenAndServe(":8080", nil) and import import _ "expvar" which should give us Prometheus metrics on localhost:8080/debug/metrics/prometheus.

jakubgs commented 5 years ago

@adambabik I know 1.9.0 has a Prometheus endpoint, i intend to start using it soon, I'm mostly doing this change because I want to keep using this piece of software to get syncing metrics which are not included in the metrics exposed by 1.9.0, which is pretty darn stupid.

jakubgs commented 5 years ago

@adambabik better? Also added a deprecation warning in the README.md.1