Closed jorge-campo closed 1 year ago
Hi, @jorge-campo. Here are my review comments, let me know if you like the suggestions or not. Thanks! :)
I think it would be interesting to use the words join and post. For example, we could say join and post in the channel instead of join and participate in the conversation. The reason I suggest this is that join and post appear in the Figma file and the UI for consequence. Moreover, participation in this context is relative, I am able to join a channel and follow its news (whitout posting/view only), and this can be classified as participating. The term post is more accurate when it refers to a task that a user can perform in a channel if they meet the token requirements.
I suggest replacing the words symbol and icon with the following: Token-gated channels show a :mobile-locked-lock: lock icon next to the channel name.
While the idea in this paragraph is accurate, I believe we should improve the text a bit. The way the information is presented is complex. I would like to share some suggestions regarding this paragraph.
switch/change --> In my opinion, both words are better than transition. Both words are in the paragraph only to illustrate my suggestions. If my suggestuin mekes sense you should choose just one word.
I could not replicate the procedure on the desktop app (0.13 release). It may be because the desktop app has not been updated yet with the Figma information.
However, I was digging in to check the information about the procedure, and I found a figma file that I believe this file is accurate. Could you confirm that this is the correct Figma file?
Thanks, @Fabiomorais87 – I'm adding my answer to your comments review here and closing this PR. If you have additional comments, you can add them to the new PR in https://github.com/status-im/status-website/pull/552
I think it would be interesting to use the words join and post.
We no longer use the term 'join' for channels, only for communities. The concept is simple: you can click/tap on any channel you have access to based on the channel configuration and the assets you own. Everything happens transparently for the user.
I suggest replacing the words symbol and icon with the following: Token-gated channels show a :mobile-locked-lock: lock icon next to the channel name.
I changed "icon" but not "symbol". We should refer to those as symbols.
If my suggestuin mekes sense you should choose just one word.
Makes sense. I've updated the paragraph following your suggestion 👍
I could not replicate the procedure on the desktop app (0.13 release). It may be because the desktop app has not been updated yet with the Figma information.
I have reproduced the scenario in the topic, and the procedure works as described in 0.14.1
Hello @Fabiomorais87 – Here is a new article for your review.
Thanks!