search

status-im / infra-eth-cluster

Infrastructure for Status-go fleets
https://github.com/status-im/status-go
0 stars 0 forks source link

Replace all "latest" tags from the status cluster configuration with git sha tags #1

Closed adambabik closed 6 years ago

adambabik commented 6 years ago

Problem

We can't use latest tag in the cluster configuration because it's a moving tag and can be updated anytime. This can break the cluster and releases compatibility easily.

Solution

The only option we have right now is to use git commit hashes in the cluster cofniguration which we push to the Docker Hub.

jakubgs commented 6 years ago

Made a PR to make sure images are always pushed with a commit tag: https://github.com/status-im/status-go/pull/1062

jakubgs commented 6 years ago

Updated infra-eth-cluster to use the cherry-picked commit @adambabik prepared for release of 0.9.21: https://github.com/status-im/infra-eth-cluster/commit/b3e5bcbdeceadab8a262d3f67c2391961215c4a8

adambabik commented 6 years ago

Thanks! https://github.com/status-im/infra-eth-cluster/commit/b3e5bcbdeceadab8a262d3f67c2391961215c4a8 closes the issue.