search

status-im / infra-role-beacon-node-linux

Ansible role for Nimbus Eth2 beacon node on Linux
https://github.com/status-im/nimbus-eth2
1 stars 4 forks source link

add support for `payload_builder` option #11

Closed Marudny closed 1 year ago

Marudny commented 1 year ago

Refers: https://github.com/status-im/nimbus-eth2/pull/3883

Signed-off-by: Artur Marud artur@status.im

Marudny commented 1 year ago

Thnx. I will add the comment. Saw the discussion and I'm not sure what URL can be set as default. Those URLs are network dependent. Maybe something dump, like: http://localhost or so.

If yes, I can create enabled flag for that in role and instead of providing URL per node in node_layout we could just enable / disable feature in specific network role for particular nodes. What do you think?

jakubgs commented 1 year ago

I'd prefer if we had an explicit *-enabled flag, but that's up to Dustin. If he doesn't want to add it then we can just do a variable for that only in Ansible. Breaks the schema of other features, but that's life I guess.

tersec commented 1 year ago

I'd prefer if we had an explicit *-enabled flag, but that's up to Dustin. If he doesn't want to add it then we can just do a variable for that only in Ansible. Breaks the schema of other features, but that's life I guess.

Yeah, I'll adjust that in the next round, maybe that PR, maybe the one for getHeader. enabled seems like a better overall approach. More explicit.