status-im / nim-blscurve

Nim implementation of BLS signature scheme (Boneh-Lynn-Shacham) over Barreto-Lynn-Scott (BLS) curve BLS12-381
Apache License 2.0
26 stars 11 forks source link

Fix compilation error because of missing vendor directory #113

Closed markspanbroek closed 3 years ago

markspanbroek commented 3 years ago

When nimble is used to add blscurve to a nim project, the following error appears:

gcc: error: ../../vendor/blst/build/assembly.S: No such file or directory
gcc: fatal error: no input files
compilation terminated.
gcc: error: ../../vendor/blst/src/server.c: No such file or directory
gcc: fatal error: no input files
compilation terminated.

This PR adds the 'vendor' directory to the list of directories that should be installed, fixing the issue.

kdeme commented 3 years ago

Cool, I encountered that issue also when working locally (outside of nimbus-eth2 repository) using nimble and in CI at https://github.com/status-im/nim-ssz-serialization/pull/1

mratsim commented 3 years ago

@markspanbroek you need to setup your GPG keys on Github to contribute to the repo (or commit directly from the Web UI)

markspanbroek commented 3 years ago

Thanks @mratsim, I updated the commit to include a GPG signature.