use builtin EIP2333 with BLST backend - Githubissues

status-im / nim-blscurve

Nim implementation of BLS signature scheme (Boneh-Lynn-Shacham) over Barreto-Lynn-Scott (BLS) curve BLS12-381

Apache License 2.0

26 stars 11 forks source link

use builtin EIP2333 with BLST backend #142

Closed mratsim closed 2 years ago

mratsim commented 2 years ago

Similar to https://github.com/status-im/nim-blscurve/commit/168fc670e5c3f6dc10e6ef52c06fe168f699fbf3

we need to guard the ADX path when building the library on 32-bit on a CPU that does support ADX. https://github.com/status-im/nim-blscurve/blob/9dda507a09c3d684f7bbf51402d2a4d81efea567/blscurve/eth2_keygen/hkdf_mod_r_blst.nim#L56-L62=

3 ways to solve this:

Remove support for EIP2333 as so far Nimbus is not officially supported to build keystores and users are redicted to deposit CLI
Add a guard !defined(__BLST_NO_ASM__) like https://github.com/supranational/blst/pull/122
Or use the new builtin EIP2333 proc introduced in BLST in May

We choose the last one.