search

status-im / nim-blscurve

Nim implementation of BLS signature scheme (Boneh-Lynn-Shacham) over Barreto-Lynn-Scott (BLS) curve BLS12-381
Apache License 2.0
26 stars 11 forks source link

update ci.yml and be more explicit in .nimble #174

Closed narimiran closed 1 month ago

tersec commented 1 month ago

Since it now depends on the nim-results package directly, https://github.com/status-im/nim-blscurve/blob/f29698d2e9a59453d99db7315a5af58add3c8715/blscurve.nimble#L13-L16 should note this by including "results",

narimiran commented 1 month ago

Since it now depends on the nim-results package directly,

https://github.com/status-im/nim-blscurve/blob/f29698d2e9a59453d99db7315a5af58add3c8715/blscurve.nimble#L13-L16

should note this by including "results",

I think your code points to an unrelated commit, because in this PR I've added results to .nimble:

https://github.com/status-im/nim-blscurve/pull/174/files#diff-9f1abdcf6f2e6d45a1f607604071183240d9a5b59762b84a39caf9ce5efdc5f1R16

https://github.com/status-im/nim-blscurve/blob/4704715486d099daf5582cc6c74ad7b6bc8b3142/blscurve.nimble#L13-L17

tersec commented 1 month ago

Since it now depends on the nim-results package directly, https://github.com/status-im/nim-blscurve/blob/f29698d2e9a59453d99db7315a5af58add3c8715/blscurve.nimble#L13-L16

should note this by including "results",

I think your code points to an unrelated commit, because in this PR I've added results to .nimble:

https://github.com/status-im/nim-blscurve/pull/174/files#diff-9f1abdcf6f2e6d45a1f607604071183240d9a5b59762b84a39caf9ce5efdc5f1R16

https://github.com/status-im/nim-blscurve/blob/4704715486d099daf5582cc6c74ad7b6bc8b3142/blscurve.nimble#L13-L17

Oops, yeah, you're right.