interop fixes - Githubissues

status-im / nim-blscurve

Nim implementation of BLS signature scheme (Boneh-Lynn-Shacham) over Barreto-Lynn-Scott (BLS) curve BLS12-381

Apache License 2.0

26 stars 11 forks source link

interop fixes #26

Closed arnetheduck closed 5 years ago

arnetheduck commented 5 years ago

add infinity point initializer for keys
use bytes8 for domain to avoid endianess issues

cheatfate commented 5 years ago

@arnetheduck are we need stew package just to keep deprecated code working? I think this is overhead. I think it will be easier to use old method with bigEndian64(addr bebuf[0], unsafeAddr domain).

arnetheduck commented 5 years ago

@cheatfate there will be more uses soon enough I suspect, there are several ways the code could be simplified with a few tricks from stew - I prefer that it's used liberally so we don't introduce tech debt unnecessarily