Closed timotheecour closed 3 years ago
nimble install https://github.com/status-im/NimYAML@#head
preceding nimble test
git submodule update
to work in nimYAML https://github.com/flyx/NimYAML/issues/77. This means that requiring the yaml package will also trigger failuresrequires https://github.com/status-im/NimYAML@#head
in a nimble file as a work-aroundPlans forward:
nimble install yaml
to be fixedSo I recommend you disable blscurve and probably all packages that requires NimYAML in the Nim CI for the time being.
In the future (a week or so), once official test vectors are available (in json format) we will remove the dependency on the current YAML test vectors (https://github.com/cfrg/draft-irtf-cfrg-hash-to-curve/pull/214)
AFAIK we can't do requires https://github.com/status-im/NimYAML@#head in a nimble file as a work-around
wouldn't that increase chances of mutually exclusive requirements, eg:
pkg1:
requires https://github.com/status-im/NimYAML@#head
pkg2:
requires https://github.com/status-im/NimYAML@#1234 #
pkg3:
requires pkg1, pkg2
the alternative is:
in any case, that discussion should happen in https://github.com/nim-lang/nimble/issues otherwise will never be fixed; maybe open an issue there and link to here?
task-level dependencies can then be achieved by (untested):
nimble install -d:with_foo mypkg
# mypkg.nimble: when defined(with_foo): requires foo
pkg3
due to conflicting requirements is not a bug.
nimble install -d:with_foo mypkg
is not really an improvement over nimble install yaml mypkg
for testing. Both require to be aware of specific testing dependencies.
/cc @mratsim
[ ] your recent commit might've caused this https://github.com/status-im/nim-blscurve/commit/f01705182204fc0df33857bb417c76115d83a2cc
[ ] wouldn't nim-blscurve's own CI prevent such regressions? => might indicate a bug in this repo's CI, which said:
9 checks passed
https://dev.azure.com/nim-lang/255dfe86-e590-40bb-a8a2-3c0295ebdeb1/_apis/build/builds/2970/logs/68
which breaks my recent PR's (eg https://github.com/nim-lang/Nim/pull/13546 )