status-im / nim-blscurve

Nim implementation of BLS signature scheme (Boneh-Lynn-Shacham) over Barreto-Lynn-Scott (BLS) curve BLS12-381
Apache License 2.0
26 stars 11 forks source link

[Tech debt] Cleanup repo #48

Closed mratsim closed 4 years ago

mratsim commented 4 years ago

Part of the tech debt week https://github.com/status-im/nim-beacon-chain/issues/867

With the varying schemes we had we have accumulated some cruft in the repo. In preparation for auditing, the code paths that are not used should be cleaned up.

For example

mratsim commented 4 years ago

Closed by #49

mratsim commented 4 years ago

Reopening

Another cleanup round: https://github.com/status-im/nim-blscurve/blob/b435f1a7296fceda8a68aaca391e6d76b2c632d3/blscurve/common.nim#L760-L801 was missed.

And when HashToCurve v7 lands and the v5 can be completely retired (probably soon as Schlesi testnet is down), we need to cleanup v5 code.

mratsim commented 4 years ago

Closed by #65