Closed mratsim closed 3 years ago
This updates EIP2333 implementation with the change to HKDF mod r from https://github.com/ethereum/EIPs/pull/2985
Concretely this is necessary to bring our own deposit tool CLI in line with the EF's: https://github.com/ethereum/eth2.0-deposit-cli
Note, the non-detailed test 0 vector was not updated while the detailed vector was, see https://github.com/ethereum/EIPs/pull/3001 and https://github.com/ethereum/eth2.0-deposit-cli/pull/108
Not merging is not exactly blocking for Spadina as a (private, public) keypair is still valid, but the derivation from master key -> (private, public) keypair changes. This impacts people rederiving their private key from their seed phrase.
This updates EIP2333 implementation with the change to HKDF mod r from https://github.com/ethereum/EIPs/pull/2985
Concretely this is necessary to bring our own deposit tool CLI in line with the EF's: https://github.com/ethereum/eth2.0-deposit-cli
Note, the non-detailed test 0 vector was not updated while the detailed vector was, see https://github.com/ethereum/EIPs/pull/3001 and https://github.com/ethereum/eth2.0-deposit-cli/pull/108
Not merging is not exactly blocking for Spadina as a (private, public) keypair is still valid, but the derivation from master key -> (private, public) keypair changes. This impacts people rederiving their private key from their seed phrase.