search

status-im / nim-chronicles

A crafty implementation of structured logging for Nim.
Apache License 2.0
153 stars 20 forks source link

`BareExcept` supposed-fix undermines library user's ability to globally disable `BareExcept` #127

Closed tersec closed 1 year ago

tersec commented 1 year ago

https://github.com/status-im/nimbus-eth2/pull/4660#issuecomment-1444385841

When taking a version of nimbus-eth2 which globally disables BareExcept in config.nims, and bumping to current master of this repository:

nimbus-eth2/vendor/nim-websock/websock/websock.nim(258, 5) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-websock/websock/websock.nim(256, 34) template/generic instantiation of `futureContinue` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/websock.nim(258, 5) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-websock/websock/websock.nim(256, 34) template/generic instantiation of `futureContinue` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/client.nim(42, 76) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/server.nim(48, 51) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/server.nim(67, 47) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/client.nim(42, 76) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/server.nim(48, 51) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/http/server.nim(67, 47) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]
nimbus-eth2/vendor/nim-websock/websock/websock.nim(258, 5) template/generic instantiation of `async` from here
nimbus-eth2/vendor/nim-websock/websock/websock.nim(256, 34) template/generic instantiation of `futureContinue` from here
nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]