status-im / nim-chronicles

A crafty implementation of structured logging for Nim.
Apache License 2.0
153 stars 20 forks source link

alternative `BareExcept` fix #128

Closed tersec closed 1 year ago

tersec commented 1 year ago

1) when (NimMajor, NimMinor) >= (1, 6) is incorrect anyway. Needs to change somehow. Nim 1.6.0 through 1.6.10 do not know about BareExcept and either will error on attempts to compile master as is, or there are deeper bugs in this code's accessibility.

2) Also, not clear why in this particular instance that except CatchableError, which is the minimal non-kludgy fix, is incorrect.

3) Current approach results in https://github.com/status-im/nim-chronicles/issues/127