Open ghost opened 6 years ago
I could have removed it if the program is not compiled with threads:on
, but in the end I decided that it was mostly harmless. The code of the logIMPL
macro is a bit simpler if it can assume that thread
will be the first properly of each log record.
Well, yeah, with the current code it's not that simple - we'll need to add checks for the first element in logIMPL
macro, some changes to how things are flushed, but I still thing that thread shouldn't be a mandatory argument for the log :)
I understand that thread ID is very useful in debugging, but really most part of Nim applications are single-threaded or async.
It's not a high priority problem though, just a suggestion.
As far as I can tell, currently there's no options to remove "thread" from the log:
Can it be implemented in some way? Maybe we can just add another compile-time define like "chronicles_threads"?