search

status-im / nim-chronos

Chronos - An efficient library for asynchronous programming
https://status-im.github.io/nim-chronos/
Apache License 2.0
362 stars 51 forks source link

make it more Nim 1.4+ compatible #296

Closed narimiran closed 2 years ago

narimiran commented 2 years ago

A continuation of https://github.com/status-im/nimbus-eth2/pull/3888

Rationale (from that link):

Currently (the latest commit in unstable branch), the CI log for the 1.6 branch has 107.000 lines. Removing every hint about cannot raise 'Defect' (including the ones in the vendor directory) leaves 16.000 lines. 85% off.

narimiran commented 2 years ago

Anything stopping this from being merged?

narimiran commented 2 years ago

Could you also fix

Can that be part of a follow-up PR? Maybe together with some fixes for UnusedImport, CStringConv, etc.?