search

status-im / nim-chronos

Chronos - An efficient library for asynchronous programming
https://status-im.github.io/nim-chronos/
Apache License 2.0
362 stars 51 forks source link

Compatibility to devel / Nim 2 + ORC #325

Closed TechThupport closed 2 years ago

TechThupport commented 2 years ago

Not really an issue but more of a clarification if chronos will be ported to be compatible with Nim devel branch or Nim 2. According to Araq the release should be happening soon or within 2022.

Menduist commented 2 years ago

The CI is ran with multiple Nim versions, including devel: https://github.com/status-im/nim-chronos/blob/master/.github/workflows/ci.yml#L25 It's impossible to guarantee devel compatibility at all time since they may break anything at anytime, but we try our best to be compatible with devel. I also think that chronos is part of the important_packages of the Nim CI

This sould be clarified in the README, indeed

TechThupport commented 2 years ago

I'm mainly getting the below error when trying to compile for windows with --mm:orc

Not sure if this is only an issue for me or what. Chronos 3.0.11 installed:

chronos/asyncmacro2.nim(126, 31) Error: 'handleRequest' is not GC-safe as it calls 'selectExt'

Found out this is only a problem when using the nim-websock library

websock-0.1.0/websock/websock.nim(258, 5) template/generic instantiation of `async` from here

It is fixed now with latest commit to websock