search

status-im / nim-chronos

Chronos - An efficient library for asynchronous programming
https://status-im.github.io/nim-chronos/docs/chronos
Apache License 2.0
353 stars 51 forks source link

check leaks after every test #487

Closed arnetheduck closed 8 months ago

cheatfate commented 8 months ago

Very confusing PR name, because leaks already got checked in all the tests, so probably should be renamed. And problem not in leaks problem is in all_tests approach. When all tests combined into single package memory usage become enormous because Nim memory manager do not release memory.

arnetheduck commented 8 months ago

Very confusing PR name, because leaks already got checked in all the tests,

leaks are checked once per suite currently - after this PR they get checked after every test - that's the difference - ie the PR title follows the naming in unittest2.

When leaks are tested once per suite, you don't know which test within a suite actually introduced the leak and have to look for it one by one - with this PR, we get a more accurate representation.