search

status-im / nim-chronos

Chronos - An efficient library for asynchronous programming
https://status-im.github.io/nim-chronos/docs/chronos
Apache License 2.0
353 stars 51 forks source link

Hash-order independent tests #550

Open c-blake opened 4 days ago

c-blake commented 4 days ago

tests/testhttpserver.nim(850, 12) and (852) fail with a new string hasher because they assume a specific order.

Any chance you guys can do something like @Vindaar did here in the next few days? Really just add a .sorted and put the @[] in sorted order.

c-blake commented 3 days ago

Sorry - I guess the line number of the test moved from the last release to the current HEAD of this repo. It was actually the area indicated by this PR.

The question remains - when is the next release of chronos planned? This error is blocking the Nim CI which is blocking a Nim-2.2 release.

c-blake commented 2 days ago

Also, tagging @arnetheduck since the release cadance of this repo is somewhat slow compared to my impression of what @Araq means by "imminent", since he was the last person to tag a release, and since he said it should be merged ASAP, but that was ambiguous between "merged under its current non-disruptive --define=nimPreviewHashFarm" or "merged as the new default with a define for the old murmur".

arnetheduck commented 1 day ago

Sorry - I guess the line number of the test moved from the last release to the current HEAD of this repo. It was actually the area indicated by this PR.

Can you open a PR for this? The link leads to a commit in your repo.

c-blake commented 1 day ago

Done. Sorry - I actually did try to do that at first and something wasn't working then. This is the PR cross-linked for convenience: https://github.com/status-im/nim-chronos/pull/551