search

status-im / nim-confutils

Simplified handling of command line options and config files
Apache License 2.0
64 stars 16 forks source link

suppress unreachable string format errors #81

Closed etan-status closed 1 year ago

etan-status commented 1 year ago

We use % and & to format some strings, which may raise ValueError if the format string is weird. As we are using them in ways that should always succeed, catch those ValueError and convert to asserts.

arnetheduck commented 1 year ago

not necessarily for this PR, but the module lacks {.push raises... I think

etan-status commented 1 year ago

Yeah, not possible yet, needs some of the other PRs before we can do that. For now, goal is to unblock https://github.com/status-im/nimbus-eth2/pull/5010