status-im / nim-confutils

Simplified handling of command line options and config files
Apache License 2.0
63 stars 16 forks source link

fail on error while processing `secondarySources` #82

Closed etan-status closed 1 year ago

etan-status commented 1 year ago

The way how secondarySources are used in status-im/nimbus-eth2, they call addConfigFile again which may raise ConfigurationError. When that happened, loading the primary config file didn't result in fail, which differs in error handling from errors within itself as opposed to within secondarySources. To keep callers concise, apply same error handling behaviour regardless of whether the error occurred during primary or secondary sources processing.

etan-status commented 1 year ago

This needs #76 / #77