search

status-im / nim-eth-common

Common types and helpers, used across nimbus related projects
Apache License 2.0
0 stars 1 forks source link

Some tweaks to AbstractChainDB #11

Closed yglukhov closed 6 years ago

yglukhov commented 6 years ago

Tweaked the interface so that its more noalloc friendly, added persistBlocks.

zah commented 6 years ago

My original intention what the this BlockHeaderRef type will be some kind of opaque handle-like value for referencing block headers. I imagined that this may be helpful for schemes where you don't keep the block information in memory, but access them from some sort of database on each API request. Obviously, this is more relevant for block bodies compared to just block headers.

Anyway, I don't mind the abandonment of the type, I'm just sharing this as a thought and consideration.