search

status-im / nim-eth-p2p

Nim Ethereum P2P protocol implementation
Apache License 2.0
11 stars 4 forks source link

fix for nim-chronicles-related compile error #45

Closed tersec closed 5 years ago

tersec commented 5 years ago

Nimble doesn't build for me without some fix to that line.

tersec commented 5 years ago

@yglukhov if it helps, the chronicles error trigger it hits is https://github.com/status-im/nim-chronicles/blob/master/chronicles/scope_helpers.nim#L29 which states Log statements should use keyword parameters to specify the log event properties.

tersec commented 5 years ago

There's at least one more instance of this; see https://github.com/status-im/nim-eth-p2p/issues/46.

yglukhov commented 5 years ago

I've tagged a new chronicles version, seems to work for me.

yglukhov commented 5 years ago

Related commit: https://github.com/status-im/nim-chronicles/commit/b35822f7d74b0cafd7d49b82da1cde00ec968d21