Treat putting empty data in hexary trie as deleting data

status-im / nim-eth

Common utilities for Ethereum

https://nimbus.status.im

Apache License 2.0

83 stars 31 forks source link

Treat putting empty data in hexary trie as deleting data #720

Closed etan-status closed 3 months ago

etan-status commented 3 months ago

Other implementations of MPT delete entries when attempting to put empty value, because empty value cannot exist in RLP. We should match the behaviour.

https://github.com/ethereum/py-trie/pull/109

Also cross-checked with Geth and Ethereumjs implementations.

etan-status commented 3 months ago

This fixes nimbus-eth2 block hash computation when there are transactions with 0 bytes, aligning it with other ELs.