status-im / nim-eth

Common utilities for Ethereum
https://nimbus.status.im
Apache License 2.0
83 stars 31 forks source link

uTP rethink / rework / remove(?) the clock drift calculator in uTP #727

Open kdeme opened 2 months ago

kdeme commented 2 months ago

There are currently some issues with it, see https://github.com/status-im/nim-eth/pull/726

After going through that code it seems there are still issues but feels very tricky to fix in its current form. I'm not sure if the idea behind it (e.g. this magic value of -200000 at which point penalties are applied) actually is effective.

So in general i think this can/should be simplified, if it is even needed at all.