status-im / nim-secp256k1

A wrapper for libsecp256k1
Apache License 2.0
10 stars 5 forks source link

ARM 32/64-bit support #16

Closed mratsim closed 4 years ago

mratsim commented 4 years ago

The current config hardcode for x86_64: https://github.com/status-im/nim-secp256k1/blob/85b2620a6e4c41eaa4caa378bd70902cff5a1c48/secp256k1_wrapper/libsecp256k1-config.h

We also need to build for x86_32, ARM32 and ARM64

stefantalpalaru commented 4 years ago

The current config hardcode for x86_64

What do you mean? It's conditional, based on architecture-specific C preprocessor defines: https://github.com/status-im/nim-secp256k1/blob/85b2620a6e4c41eaa4caa378bd70902cff5a1c48/secp256k1_wrapper/libsecp256k1-config.h#L63

mratsim commented 4 years ago

Yes, actually the config file seems to be informative and not enforcing anything during compilation