RFC: reorg repo a bit - Githubissues

status-im / nim-secp256k1

A wrapper for libsecp256k1

Apache License 2.0

7 stars 5 forks source link

RFC: reorg repo a bit #19

Closed arnetheduck closed 4 years ago

arnetheduck commented 4 years ago

Currently we have two "adapters" (https://github.com/status-im/nim-eth/blob/master/eth/keys/secp.nim and https://github.com/status-im/nim-libp2p/blob/master/libp2p/crypto/secp.nim) of the raw interface found in this repo - to join them together, I'd like to:

rename https://github.com/status-im/nim-secp256k1/blob/master/secp256k1.nim to secp256k1_abi.nim in line with https://github.com/arnetheduck/nim-sqlite3-abi/blob/master/sqlite3_abi.nim as it exports the raw C ABI to nim
move https://github.com/status-im/nim-eth/blob/master/eth/keys/secp.nim to secp256k1 in this repo
use in both nim-eth and nim-libp2p

Plan B would be to create a separate ABI repo and a nice repo on top, but this seems overkill.

Also, we have some modifications to upstream (https://github.com/status-im/secp256k1/pull/2/commits/4afc920fe79fc5c853fc76638ada8101e9aba377 and https://github.com/status-im/secp256k1/pull/2/commits/1766dc808621f8a6e91282a321ddabce4352e624) - these could potentially be moved into this repo so that we rely on a "clean" upstream repo.