search

status-im / nim-stew

stew is collection of utilities, std library extensions and budding libraries that are frequently used at Status, but are too small to deserve their own git repository.
139 stars 18 forks source link

Revert "Normalise `KeyError` exception message" #132

Closed tersec closed 2 years ago

tersec commented 2 years ago

Reverts status-im/nim-stew#119

See if this re-establishes CI passing. If so, I intend to merge it.

It's a nice enough change, it's fine, and if it points to some compiler bug which needs to be fixed, that's useful, but it can/should be done in a branch that's not named master.

tersec commented 2 years ago

This isn't the culprit, or at least reverting it doesn't prevent exactly the same issues arising, in "Test using VCC" with Nim 1.2:

stdlib_system.nim.c
C:\Users\runneradmin\nimcache\all_tests_d\stdlib_io.nim.c(1095): warning C4020: '_setjmp': too many actual parameters
C:\Users\runneradmin\nimcache\all_tests_d\stdlib_io.nim.c(1095): error C2167: '_setjmp': too many actual parameters for intrinsic function
Error: execution of an external compiler program 'cl.exe /c /nologo -DWIN32_LEAN_AND_MEAN   /ID:\a\nim-stew\nim-stew\nim\lib /ID:\a\nim-stew\nim-stew\tests /FoC:\Users\runneradmin\nimcache\all_tests_d\stdlib_io.nim.c.obj C:\Users\runneradmin\nimcache\all_tests_d\stdlib_io.nim.c' failed with exit code: 2
stack trace: (most recent call last)
D:\a\_temp\msys64\tmp\nimblecache-3274857584\nimscriptapi_1597988600.nim(187, 16)
D:\a\nim-stew\nim-stew\stew.nimble(35, 8) testvccTask
D:\a\nim-stew\nim-stew\stew.nimble(25, 8) test
D:\a\nim-stew\nim-stew\nim\lib\system\nimscript.nim(260, 7) exec
D:\a\nim-stew\nim-stew\nim\lib\system\nimscript.nim(260, 7) Error: unhandled exception: FAILED: nim c  --cc:vcc --threads:off -r --hints:off --skipParentCfg --styleCheck:usages --styleCheck:hint tests/all_tests [OSError]
     Error: Exception raised during nimble script execution
C:\Users\runneradmin\nimcache\all_tests_d\stdlib_system.nim.c(5788): warning C4020: '_setjmp': too many actual parameters
C:\Users\runneradmin\nimcache\all_tests_d\stdlib_system.nim.c(5788): error C2167: '_setjmp': too many actual parameters for intrinsic function
Error: Process completed with exit code 1.

and for Nim 1.6, "Test using VCC" on Windows, similarly:

C:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem@sio.nim.c(1256): warning C4020: '_setjmp': too many actual parameters
Error: execution of an external compiler program 'cl.exe /c /nologo -DWIN32_LEAN_AND_MEAN   /ID:\a\nim-stew\nim-stew\nim\lib /ID:\a\nim-stew\nim-stew\tests /nologo /FoC:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem@sio.nim.c.obj C:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem@sio.nim.c' failed with exit code: 2
C:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem@sio.nim.c(1256): error C2167: '_setjmp': too many actual parameters for intrinsic function
stack trace: (most recent call last)
     Error: Exception raised during nimble script execution
D:\a\_temp\msys64\tmp\nimblecache-3274857584\nimscriptapi_13701037.nim(187, 16)
D:\a\nim-stew\nim-stew\stew.nimble(35, 8) testvccTask
D:\a\nim-stew\nim-stew\stew.nimble(25, 8) test
D:\a\nim-stew\nim-stew\nim\lib\system\nimscript.nim(273, 7) exec
D:\a\nim-stew\nim-stew\nim\lib\system\nimscript.nim(273, 7) Error: unhandled exception: FAILED: nim c  --cc:vcc --threads:off -r --hints:off --skipParentCfg --styleCheck:usages --styleCheck:error tests/all_tests [OSError]
C:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem.nim.c(4855): warning C4020: '_setjmp': too many actual parameters
C:\Users\runneradmin\nimcache\all_tests_d\@m..@snim@slib@ssystem.nim.c(4855): error C2167: '_setjmp': too many actual parameters for intrinsic function
Error: Process completed with exit code 1.