search

status-im / nim-stew

stew is collection of utilities, std library extensions and budding libraries that are frequently used at Status, but are too small to deserve their own git repository.
139 stars 18 forks source link

Deprecate baseType #148

Closed Menduist closed 1 year ago

Menduist commented 1 year ago

From a quick sweep in our repos, no one uses it It's based on quite unsafe behavior, doesn't give the same results with arc/orc, and I'm pretty sure a macro could do it, if we need it

ringabout commented 1 year ago

BTW, the previous CI consumes lots of resources, and now it is queued. How about only running the CI on the latest commit and cancel the previous ones. The Nim repo has been doing this without a hitch.

ref https://stackoverflow.com/questions/66335225/how-to-cancel-previous-runs-in-the-pr-when-you-push-new-commitsupdate-the-curre/72408109#72408109

arnetheduck commented 1 year ago

BTW, the previous CI consumes lots of resources,

we'll happily take patches for this, though in the case of stew the jobs are pretty fast so it hasn't been a prio fixing it - it's a good idea in general though, indeed